Remove access() call from Snapsafe detection #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2197 +/- ##
==========================================
- Coverage 79.04% 79.03% -0.01%
==========================================
Files 612 612
Lines 106067 106218 +151
Branches 14985 15005 +20
==========================================
+ Hits 83842 83953 +111
- Misses 21571 21612 +41
+ Partials 654 653 -1 ☔ View full report in Codecov by Sentry. |
justsmth
reviewed
Feb 18, 2025
justsmth
previously approved these changes
Feb 18, 2025
torben-hansen
previously approved these changes
Feb 18, 2025
justsmth
previously approved these changes
Feb 19, 2025
justsmth
reviewed
Feb 19, 2025
smittals2
dismissed stale reviews from justsmth and torben-hansen
via
f83eb44
torben-hansen
approved these changes
Feb 19, 2025
justsmth
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change uses stat() instead of access() to check for the existence of the Sysgenid device. This is more accurate to ascertain whether the device exists on a machine. access() could fail for various other reasons such as missing permissions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.